[SCB-754] add null pointer check on AbstractRestInvocation.invocation#817
Merged
Conversation
yhs0092
force-pushed
the
check_null_invocation
branch
from
f1bec2d to
ecf8e8e
Compare
liubao68
reviewed
Jul 18, 2018
|
|
||
| restInvocation.sendResponseQuietly(response); | ||
|
|
||
| // just log, check nothing, and should not throw NPE |
Contributor
There was a problem hiding this comment.
Can we add an integration test for this scenario? Define a filter may not throw null and call a not exists service and got a 404.
liubao68
approved these changes
Jul 19, 2018
wujimin
approved these changes
Jul 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.See details in SCB-754