[SCB-841] move string type test case from demo to integration-test #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
不要合入，有些细节需要改，主要是变量名 |
Contributor
|
Any updates? |
Contributor
Author
|
sure, i will finish it this weekend. |
Contributor
|
i will change the base code, make it simpler, please update after my PR merged. |
Contributor
Author
|
ok, i see. |
liubao68
reviewed
Sep 10, 2018
| @ApiImplicitParams({ | ||
| @ApiImplicitParam(name = "input", dataType = "string", paramType = "form", value = "a required form param", required = true, defaultValue = "string")}) | ||
| @PostMapping(path = "stringFormRequire") | ||
| public String stringFormRequire(String input) { |
Contributor
There was a problem hiding this comment.
This test case is confusion, because it has two parameters named "input", one is body(json string) and the other is form. How would this work?
liubao68
reviewed
Sep 10, 2018
|
|
||
| //string | ||
|
|
||
| public String stringBody(String input) { |
Contributor
There was a problem hiding this comment.
This two methods never invoked in this PR
Contributor
Author
There was a problem hiding this comment.
sorry, there is some thing wrong when I merge the new updates, I forget to delete it
liubao68
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.