Skip to content

[SCB-860] Optimize microservice register process, abort registry when query microservice id fails#880

Closed
yhs0092 wants to merge 1 commit intoapache:masterfrom
yhs0092:abort_registry_when_query_microservice_id_fails
Closed

[SCB-860] Optimize microservice register process, abort registry when query microservice id fails#880
yhs0092 wants to merge 1 commit intoapache:masterfrom
yhs0092:abort_registry_when_query_microservice_id_fails

Conversation

@yhs0092
Copy link
Member

@yhs0092 yhs0092 commented Aug 21, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See details in SCB-860

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 86.202% when pulling e5d74aa on yhs0092:abort_registry_when_query_microservice_id_fails into 3c7f128 on apache:master.

@wujimin
Copy link
Contributor

wujimin commented Aug 30, 2018

discussed
no need to do this change, just close it.

@wujimin wujimin closed this Aug 30, 2018
@yhs0092 yhs0092 deleted the abort_registry_when_query_microservice_id_fails branch September 8, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants