[SCB-950] modify consumer producer metrics and add edge metrics #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
reviewed
Oct 7, 2018
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class MeterDetailStatisticsModel { |
Contributor
There was a problem hiding this comment.
why need this model?
enum the stages, just like the old logic, seems simpler?
Contributor
Author
There was a problem hiding this comment.
well. the data structure is different with before.
for example:
old:
rest.200:
xx xxx xx xx sayHi
xxx xx xx xx sayHello
rest.400:
xx xxx xx xx sayHi
xxx xx xx xx sayHello
now:
sayHi:
rest200:
xx xx xxx
rest400:
xx xx xxx
sayHello:
rest200:
xx xx xxx
rest400:
xx xx xxx
Hence, I have to load all data, And then restructure it
wujimin
reviewed
Oct 7, 2018
| } | ||
| sb.append(String.format(SIMPLE_HEADER, "edge")); | ||
| //clear old data | ||
| MeterStatisticsManager.statisticsOperationMap.clear(); |
Contributor
Author
There was a problem hiding this comment.
I just use it to load data temporarily as I need restructure the data
Contributor
Author
There was a problem hiding this comment.
I have removed the global variable
wujimin
approved these changes
Oct 8, 2018
liubao68
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.