[SCB-1021] Add vertx client server meters#997
Merged
liubao68 merged 10 commits intoapache:masterfrom Nov 24, 2018
Merged
Conversation
wujimin
force-pushed
the
add-vertx-client-server-meters
branch
2 times, most recently
from
9dfa972 to
2c95a52
Compare
liubao68
approved these changes
Nov 20, 2018
yhs0092
approved these changes
Nov 20, 2018
heyile
reviewed
Nov 21, 2018
| // so need to support node not exist | ||
| public double findChildAndSummary(String childName) { | ||
| MeasurementNode node = findChild(childName); | ||
| return node != null ? node.summary() : 0; |
Contributor
There was a problem hiding this comment.
only return 0 is ok ? can we prevent the lost of measurements, maybe we can shorter the interval of gaugePollingFrequency
Contributor
Author
There was a problem hiding this comment.
too expensive
first time and expired is rare event, just make it not cause problem is enough
wujimin
force-pushed
the
add-vertx-client-server-meters
branch
from
d24c0e3 to
0952bbe
Compare
added 10 commits
November 23, 2018 14:38
wujimin
force-pushed
the
add-vertx-client-server-meters
branch
from
0952bbe to
ab21b7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.