Closed
Conversation
tianxiaoliang
force-pushed
the
dev
branch
4 times, most recently
from
27c7a94 to
e91f80c
Compare
zhulijian1
reviewed
Mar 26, 2020
| "domain": domain, | ||
| }, | ||
| )) | ||
| return cursorToOneKV(ctx, cur, opts.Labels) |
Contributor
There was a problem hiding this comment.
cursorToOneKV函数应该没有别处调用了吧，没的话就删了吧
zhulijian1
reviewed
Mar 26, 2020
| var err error | ||
| project := rctx.ReadPathParameter(PathParameterProject) | ||
| domain := ReadDomain(rctx) | ||
| kvID := rctx.ReadQueryParameter(common.QueryParamKeyID) |
Contributor
There was a problem hiding this comment.
URLPatterns和API文档添上这个parameters
zhulijian1
reviewed
Mar 26, 2020
| if kvID != "" { | ||
| kv, err := service.KVService.Get(rctx.Ctx, domain.(string), project, kvID) | ||
| if err != nil { | ||
| WriteErrResponse(rctx, http.StatusBadRequest, err.Error(), common.ContentTypeText) |
Contributor
There was a problem hiding this comment.
不一定是BadRequest，可能是数据库内部错误、decode err和没找到
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.