SCB-1325 Refactoring the delete function#14
Closed
wangqj wants to merge 3 commits intoapache:masterfrom
wangqj:master
Closed
SCB-1325 Refactoring the delete function#14wangqj wants to merge 3 commits intoapache:masterfrom wangqj:master
wangqj wants to merge 3 commits intoapache:masterfrom
wangqj:master
Conversation
tianxiaoliang
requested changes
Jun 29, 2019
server/resource/v1/kv_resource.go
Outdated
| }, { | ||
| Method: http.MethodDelete, | ||
| Path: "/v1/kv/{ids}", | ||
| Path: "/v1/kv/", |
Contributor
There was a problem hiding this comment.
Path: "/v1/kv/",
since param is path parameters, I guess you shoult write this Path right
| err = s.Delete(kvID, labelID, domain.(string)) | ||
| if err != nil { | ||
| openlogging.Error(fmt.Sprintf("delete ids=%s,err=%s", ids, err.Error())) | ||
| openlogging.Error(fmt.Sprintf("delete kvID=%s,labelID=%s,error=%s", kvID, labelID, err.Error())) |
Contributor
There was a problem hiding this comment.
from now use structured logging, refer to som of my log code call "WithTag"
Contributor
|
and write rest api level UT plz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related https://issues.apache.org/jira/browse/SCB-1325