add kubernets script and doc#149
Merged
tianxiaoliang merged 3 commits intoapache:masterfrom Aug 5, 2020
Merged
Conversation
tianxiaoliang
requested changes
Aug 3, 2020
| - name: MONGODB_USER | ||
| value: kie | ||
| - name: MONGODB_PWD | ||
| value: '123' |
Contributor
There was a problem hiding this comment.
交付的应该是可按需配置的方案，所以应该提供install.sh脚本允许定制用户名密码这些配置
| - name: MONGODB_PWD | ||
| value: '123' | ||
| - name: MONGODB_ADDR | ||
| value: localhost |
Contributor
There was a problem hiding this comment.
db的地址不该是配死的，而是k8s service的name，通过name进行发现
tianxiaoliang
requested changes
Aug 5, 2020
| - name: down-init-db-js | ||
| image: busybox | ||
| volumeMounts: | ||
| - name: mongo-init-pvs |
Contributor
There was a problem hiding this comment.
PersistentVolumeClaim 应该缩写为pvc
Contributor
Author
There was a problem hiding this comment.
这个不是PersistentVolumeClaim，而是PersistentVolumeStorage, 简写pvs
tianxiaoliang
requested changes
Aug 5, 2020
docs/getstarted/install.md
Outdated
| - mongodb UI:http://127.0.0.1:8081 | ||
| - servicecomb-kie: http://127.0.0.1:30110 | ||
|
|
||
| ### Run with Docker kubernetes |
| environment: | ||
| ME_CONFIG_MONGODB_ADMINUSERNAME: kie | ||
| ME_CONFIG_MONGODB_ADMINPASSWORD: 123 | ||
| ME_CONFIG_MONGODB_SERVER: mongo |
Contributor
Author
There was a problem hiding this comment.
这个是默认值，就是连mongo的service的host,原来的也能工作，只是不清晰。
tianxiaoliang
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tianxiaoliang