Skip to content
This repository was archived by the owner on Oct 13, 2024. It is now read-only.

[SCB-167] proper connection & disconnection#103

Merged
WillemJiang merged 3 commits intomasterfrom
SCB-167_proper_connection
Jan 5, 2018
Merged

[SCB-167] proper connection & disconnection#103
WillemJiang merged 3 commits intomasterfrom
SCB-167_proper_connection

Conversation

@seanyinx
Copy link
Member

@seanyinx seanyinx commented Jan 5, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Signed-off-by: seanyinx <sean.yin@huawei.com>
Signed-off-by: seanyinx <sean.yin@huawei.com>
Signed-off-by: seanyinx <sean.yin@huawei.com>
@seanyinx seanyinx requested a review from WillemJiang January 5, 2018 07:34
@seanyinx
Copy link
Member Author

seanyinx commented Jan 5, 2018

@eric-lee-ltk please review

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 94.94% when pulling d3ecced on SCB-167_proper_connection into d38641a on master.

@eric-lee-ltk
Copy link
Contributor

LGTM

@WillemJiang WillemJiang merged commit fdce17b into master Jan 5, 2018
@seanyinx seanyinx deleted the SCB-167_proper_connection branch January 12, 2018 03:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants