This repository was archived by the owner on Oct 13, 2024. It is now read-only.
SCB-213 proper timing to handle SagaEndedEvent in asynchronous situation#111
Merged
Conversation
Signed-off-by: Eric Lee <dagang.li@huawei.com>
Signed-off-by: Eric Lee <dagang.li@huawei.com>
seanyinx
reviewed
Jan 11, 2018
| events.forEach(omegaCallback::compensate); | ||
| eventsToCompensate.computeIfAbsent(event.globalTxId(), (v) -> { | ||
| CopyOnWriteArraySet<String> eventSet = new CopyOnWriteArraySet<>(); | ||
| events.forEach(e -> eventSet.add(getUniqueEventId(e))); |
Member
There was a problem hiding this comment.
what's the performance characteristics of CopyOnWrite?
Contributor
Author
There was a problem hiding this comment.
There is no need to use CopyOnWriteArraySet as the set is only write once. Already used HashSet instead.
| } | ||
|
|
||
| private String getUniqueEventId(TxEvent event) { | ||
| return event.globalTxId() + "_" + event.localTxId(); |
Member
There was a problem hiding this comment.
the map is based on globalTxId. why use globalTxId again?
Contributor
Author
There was a problem hiding this comment.
That's a good point. Use localTxId is enough.
Signed-off-by: Eric Lee <dagang.li@huawei.com>
seanyinx
reviewed
Jan 11, 2018
| if (events != null) { | ||
| events.remove(event.localTxId()); | ||
| if (events.isEmpty()) { | ||
| markGlobalTxEnd(event); |
Member
There was a problem hiding this comment.
how about remove the set from map, or it will keep growing?
Signed-off-by: Eric Lee <dagang.li@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Lee dagang.li@huawei.com
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.