This repository was archived by the owner on Oct 13, 2024. It is now read-only.
Merged
Conversation
The support for legacy mode will be dropped, remove all the related code from master branch.
eric-lee-ltk
reviewed
Mar 2, 2018
| @@ -1,53 +0,0 @@ | |||
| # Previous Saga's Documentation | |||
Contributor
There was a problem hiding this comment.
We should also remove the entry of this file in both README.md and README_ZH.md.
eric-lee-ltk
reviewed
Mar 2, 2018
| See [Saga API](docs/api/api.md) for details. | ||
|
|
||
| ## Example | ||
| See [Saga demo](https://github.com/apache/incubator-servicecomb-saga/tree/master/saga-demo) for details. |
Contributor
There was a problem hiding this comment.
Maybe we should also rename the saga-demo/pack-demo to be something else like saga-demo/booking as it seems kinds of weird. Besides, after renaming the name, please update the demo entry in README and README_ZH.
WillemJiang
approved these changes
Mar 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support for legacy mode will be dropped, remove all the related
code from master branch.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.