This repository was archived by the owner on Oct 13, 2024. It is now read-only.
[SCB-452] Write java doc for some class and some refactoring.#166
Merged
WillemJiang merged 4 commits intoapache:masterfrom Apr 2, 2018
chanjarster:SCB-452
Merged
[SCB-452] Write java doc for some class and some refactoring.#166WillemJiang merged 4 commits intoapache:masterfrom chanjarster:SCB-452
WillemJiang merged 4 commits intoapache:masterfrom
chanjarster:SCB-452
Conversation
…dTxStartedEvent. The "ToCompensate" phrase in the original method name doesn't match the underlying code logic.
… method Change method signature from findFirstCompensatedEventByIdGreaterThan(long id, String type) to findFirstCompensatedEventByIdGreaterThan(long id). The purpose of this method implied by name is to find a TxCompensatedEvent, so the type param is redundant.
…terThan() Change method signature from List<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id, String type); to Optional<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id); Reasons: 1. this method named "findFirst" and it always returns a list with 1 element or an empty list, so it's better to return Optional<>. 2. this method try to find a TxEndedEvent which is aborted but not compensated, so the parameter type should not be exposed to callers, it should be in internal query logic.
WillemJiang
approved these changes
Apr 2, 2018
Member
WillemJiang
left a comment
WillemJiang
left a comment
There was a problem hiding this comment.
Hi Daniel, Thanks to go through the code by adding java doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.