Skip to content
This repository was archived by the owner on Oct 13, 2024. It is now read-only.

Conversation

@oliugian
Copy link
Contributor

@coveralls
Copy link

coveralls commented Aug 28, 2018

Coverage Status

Coverage decreased (-0.1%) to 93.674% when pulling 70b7e78 on oliugian:master into 1a95b10 on apache:master.

2. Enter the saga dubbo demo directory and give permissions to script
```
cd ./saga-demo/saga-dubbo-demo
chmod +x saga-dubbo-demo.sh
Copy link
Member

@WillemJiang WillemJiang Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the file property of the sh file , it has the executor right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has no executor right when first use,or shall we use like bash saga-dubbo-demo.sh?

<artifactId>mysql-connector-java</artifactId>
</dependency>
```
2. remove alpha server's docker image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alpha server docker image could be overridden when we regenerate the docker image.
So we don't need to remove the alpha server docker image here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will change it

http://${host_address}:8071/serviceInvoke/BExceptionWhenAb
```
## Debugging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the debugging information here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,i will change it

1. run the following command to create docker images in saga project root folder.
```
mvn clean package -DskipTests -Pdocker -Pdemo
mvn clean install -DskipTests -Pdocker -Pdemo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package doesn't install the jars into maven directory. We don't need to use install here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when first use,if you do not use mvn install in saga root project folder,it will got an error when use mvn help:evaluate in saga-demo.sh to get version of docker image.

[INFO] Scanning for projects...
[INFO] mixin-maven-plugin: Merging Mixins
[ERROR] Cannot resolve mixin artifact org.apache.servicecomb.saga:docker-build-config:pom:0.3.0-SNAPSHOT: Error resolving artifact org.apache.servicecomb.saga:docker-build-config:pom:0.3.0-SNAPSHOT -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,we can keep the change here.

@WillemJiang WillemJiang merged commit f54e7e8 into apache:master Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants