Skip to content
This repository was archived by the owner on Oct 13, 2024. It is now read-only.

Comments

[SCB-864] support multiple parameters for each sql#286

Merged
WillemJiang merged 5 commits intoapache:masterfrom
KomachiSion:SCB-864
Sep 4, 2018
Merged

[SCB-864] support multiple parameters for each sql#286
WillemJiang merged 5 commits intoapache:masterfrom
KomachiSion:SCB-864

Conversation

@KomachiSion
Copy link
Member

@KomachiSion KomachiSion commented Sep 3, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Sep 3, 2018

Coverage Status

Coverage remained the same at 93.873% when pulling a93f531 on KomachiSion:SCB-864 into 63d7193 on apache:master.

private final List<List<Object>> params;

public SQLOperation(String sql, List<String> params) {
public SQLOperation(String sql, List<List<Object>> params) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params are string type. Why do you change it to Object?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params may be Integer, Date. so I think Object may be more suitable than String?

@WillemJiang WillemJiang merged commit fae0e85 into apache:master Sep 4, 2018
@KomachiSion KomachiSion deleted the SCB-864 branch October 19, 2018 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants