Skip to content
This repository was archived by the owner on Oct 13, 2024. It is now read-only.

[SCB-2199] Add GitHub Actions workflows#698

Merged
zhfeng merged 1 commit intoapache:masterfrom
coolbeevip:SCB-2199
Mar 2, 2021
Merged

[SCB-2199] Add GitHub Actions workflows#698
zhfeng merged 1 commit intoapache:masterfrom
coolbeevip:SCB-2199

Conversation

@coolbeevip
Copy link
Member

  • Add a CI workflow for PRs and push branch master

@zhfeng
Copy link
Contributor

zhfeng commented Mar 2, 2021

Thanks @coolbeevip - Nice work !

Is it possible to remove the travis configration if we make sure github flow works ?

if: ${{ success() }}
run: ./mvnw clean install -B -Pdocker
- name: Upload unit test results when the previous step of a job fails
if: ${{ failure() }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we do this if the tests are failed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the test fails, the unit test report will be uploaded to Github for easy download through the Github web interface

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense.

@coolbeevip
Copy link
Member Author

Thanks @coolbeevip - Nice work !

Is it possible to remove the travis configration if we make sure github flow works ?

Build and tests passed in my forked repository https://github.com/coolbeevip/servicecomb-pack/actions/runs/612410941
But Sonar and Coverage have not been added yet. I will add sonar and coverage in other PRs and remove the travis config

@zhfeng
Copy link
Contributor

zhfeng commented Mar 2, 2021

@coolbeevip can you squash all the commits before merging ?

@coolbeevip
Copy link
Member Author

@coolbeevip can you squash all the commits before merging ?

done

@zhfeng zhfeng merged commit 549d5c5 into apache:master Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants