new houserush sample framework#11
new houserush sample framework#11yhs0092 merged 2 commits intoapache:masterfrom alec-z:new_houserush_sample
Conversation
|
Hello, I find that the indent of some files is different from the others. It's recommended to use the same code format template, and you can find it in ServiceComb-Java-Chassis. |
|
@yhs0092 I have |
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
We need to add Apache License.
WillemJiang
left a comment
WillemJiang
left a comment
There was a problem hiding this comment.
It's strange this PR has no Java code yet.
I add some comments on the pom.xml please check them out.
| <artifactId>spring-boot-starter-data-jpa</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>mysql</groupId> |
There was a problem hiding this comment.
We cannot use the mysql connector due to the license issue, please switch it to postgresql.
There was a problem hiding this comment.
I will change it, thx.
| <plugin> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-maven-plugin</artifactId> | ||
| <version>2.0.1.RELEASE</version> |
There was a problem hiding this comment.
You may need to consider to upgrade the spring boot version, as this one is pretty old.
3 participants
Add the new e-commerce sample project framework as my proposal says. It's just the pom files and the microservices split design. @liubao68