SCB-1426 Support for configuring the toolkit maven plugin in the parent pom#14
Merged
MabinGo merged 4 commits intoapache:masterfrom Aug 8, 2019
Merged
SCB-1426 Support for configuring the toolkit maven plugin in the parent pom#14MabinGo merged 4 commits intoapache:masterfrom
MabinGo merged 4 commits intoapache:masterfrom
Conversation
…nt pom Signed-off-by: kakulisen <18813972746@163.com>
Signed-off-by: kakulisen <18813972746@163.com>
Signed-off-by: kakulisen <18813972746@163.com>
Signed-off-by: kakulisen <18813972746@163.com>
Contributor
|
LGTM |
WillemJiang
reviewed
Aug 8, 2019
| } | ||
|
|
||
| @Test | ||
| public void externalConfigGenerator() { |
Member
There was a problem hiding this comment.
I don't think we need to add unit test for constant.
Contributor
Author
There was a problem hiding this comment.
Thank you for reminding me, I will modify it in the next pr
kakulisen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for configuring the toolkit maven plugin in the parent pom and generated microservice project support name configurable