SCB-1580 Configurable oas style check rules#52
Merged
WillemJiang merged 10 commits intoapache:masterfrom Nov 21, 2019
Merged
Conversation
Make ValidatorFactory create validators by options
Remove oas-validator-compliance-spring because we use ValidatorFactory to create validators.
Provide unit test for ValidatorFactory
Remove useless spring configurations
Update cli usage
Update oas-validator-web
Add license headers
Modify test script, make it usable in local environment
Update README
WillemJiang
reviewed
Nov 20, 2019
Member
WillemJiang
left a comment
WillemJiang
left a comment
There was a problem hiding this comment.
too many line to review.
Can you summarize what did you do?
| * oas-validator-core-spring，骨架的Spring Boot Starter | ||
| * oas-validator-test，核心API的测试帮助类 | ||
| * oas-validator-compliance，合规性校验实现 | ||
| * oas-validator-compliance-spring，合规性校验的Spring Boot Starter |
Member
There was a problem hiding this comment.
why did you remove this line.
Member
Author
There was a problem hiding this comment.
oas-validator-compliance-spring directly @configuration *Validator beans, which are not configurable. While we use *ValidatorFactory now, so we can abandon it.
Related commit:
Member
Author
|
@WillemJiang what this PR does are:
|
WillemJiang
approved these changes
Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.