Skip to content

Conversation

@Xu-Wentao
Copy link
Collaborator

@Xu-Wentao Xu-Wentao commented May 10, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • move storage node unit test used fakeclient to controllers, just left envtest case in test/e2e package.
  • add check lint to download golangci-lint if is not setup. user can use make lint to lint code now.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #353 (5eeb4f1) into main (6c3683b) will decrease coverage by 4.08%.
The diff coverage is 15.61%.

❗ Current head 5eeb4f1 differs from pull request most recent head 0730957. Consider uploading reports for the commit 0730957 to get more accurate results

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   45.74%   41.67%   -4.08%     
==========================================
  Files          47       44       -3     
  Lines        5032     4773     -259     
==========================================
- Hits         2302     1989     -313     
- Misses       2561     2631      +70     
+ Partials      169      153      -16     
Impacted Files Coverage Δ
...pkg/controllers/shardingsphere_chaos_controller.go 0.00% <0.00%> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 0.00% <0.00%> (ø)
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <ø> (ø)
...perator/pkg/controllers/storage_node_controller.go 40.65% <17.75%> (-27.37%) ⬇️
...rator/pkg/reconcile/storagenode/aws/rdsinstance.go 22.46% <26.76%> (+6.46%) ⬆️
pitr/cli/pkg/httputils/req.go 21.91% <69.23%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Xu-Wentao Xu-Wentao force-pushed the storage-node branch 3 times, most recently from 5c53ba0 to dd4cedd Compare May 10, 2023 05:51
@mlycore mlycore added type: refactor operator solutions of operator in: test modules of test in: e2e modules of e2e test labels May 10, 2023
@mlycore mlycore added this to the 0.3.0 milestone May 10, 2023
wbtlb
wbtlb previously approved these changes May 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wbtlb
Copy link
Contributor

wbtlb commented May 10, 2023

approve

@mlycore mlycore merged commit a697577 into apache:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: e2e modules of e2e test in: test modules of test operator solutions of operator type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants