#11397 fix bug of wrong route result#11626
Conversation
tristaZero
left a comment
tristaZero
left a comment
There was a problem hiding this comment.
@vince7839 Hi, thanks for your bug-fix. I am glad to see your feedback after you raised the issue. Could you add a UT in ExpressionBuilderTest to verify your modification?
@strongduanmu Could you have a review here?
|
@vince7839 Thank you for your pr, can you add some test case(unit test, rewrite test) for it? |
| result.getAndPredicates().add(createAndPredicate(eachLeft, eachRight)); | ||
| } | ||
| } | ||
| processAndExpression(result); |
There was a problem hiding this comment.
@vince7839 Maybe result.getAndPredicates().addAll(createAndPredicates()) is better.
There was a problem hiding this comment.
Do you mean changing the method of "processAndExpression()" to "createAndPredicates()"?
There was a problem hiding this comment.
Do you mean changing the method of "processAndExpression()" to "createAndPredicates()"?
@vince7839 Yes.
There was a problem hiding this comment.
Okay,I'll do it and add UT
4 participants
Fixes #11397.
Changes proposed in this pull request: