Refactor single table meta data load#11895
Refactor single table meta data load#11895tristaZero merged 19 commits intoapache:masterfrom tuichenchuxin:refactor_meta_data_load
Conversation
…load # Conflicts: # shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/dialect/OracleTableMetaDataLoader.java
Codecov Report
@@ Coverage Diff @@
## master #11895 +/- ##
============================================
+ Coverage 62.94% 63.01% +0.07%
- Complexity 1216 1228 +12
============================================
Files 2296 2302 +6
Lines 34891 34870 -21
Branches 6071 6059 -12
============================================
+ Hits 21961 21974 +13
+ Misses 11148 11114 -34
Partials 1782 1782
Continue to review full report at Codecov.
|
...rc/test/java/org/apache/shardingsphere/encrypt/metadata/EncryptTableMetaDataBuilderTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/shardingsphere/encrypt/metadata/EncryptTableMetaDataBuilderTest.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Show resolved
Hide resolved
...-infra-common/src/main/java/org/apache/shardingsphere/infra/rule/single/SingleTableRule.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptTableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/shardingsphere/sharding/metadata/ShardingTableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/shardingsphere/infra/metadata/schema/builder/TableMetaDataBuilder.java
Outdated
Show resolved
Hide resolved
...java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/TableMetaDataLoader.java
Outdated
Show resolved
Hide resolved
| private Optional<TableMetaData> loadTableByDataNode(final DataNode dataNode, final DatabaseType databaseType, final Map<String, DataSource> dataSourceMap) { | ||
| try { | ||
| return TableMetaDataLoader.load(dataSourceMap.get(dataNode.getDataSourceName()), dataNode.getTableName(), databaseType); | ||
| return DefaultTableMetaDataLoader.load(dataSourceMap.get(dataNode.getDataSourceName()), dataNode.getTableName(), databaseType); |
There was a problem hiding this comment.
@tuichenchuxin Is it possible to use TableMetaDataLoaderEngine to load?
There was a problem hiding this comment.
@tuichenchuxin Is it possible to use TableMetaDataLoaderEngine to load?
At present, there are still some scenarios where DefaultTableMetaDataLoader.load is called separately, which has a lot of impact and has not been modified for the time being. In the future, the logic needs to be unified into the TableMetaDataLoaderEngine.
Fixes #11718.
Changes proposed in this pull request:
TableMetaDataBuilderTableMetaDataLoader