Add dataConsistencyCheckAlgorithm default implementation and DataConsistencyChecker refactor#12653
Merged
tristaZero merged 15 commits intoapache:masterfrom Sep 23, 2021
Merged
Add dataConsistencyCheckAlgorithm default implementation and DataConsistencyChecker refactor#12653tristaZero merged 15 commits intoapache:masterfrom
tristaZero merged 15 commits intoapache:masterfrom
Conversation
…e type could be different
tristaZero
approved these changes
Sep 23, 2021
tristaZero
approved these changes
Sep 23, 2021
...org/apache/shardingsphere/scaling/core/job/check/consistency/DataConsistencyCheckerImpl.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12615.
Changes proposed in this pull request:
SingleTableDataCalculatorand default implScalingDataConsistencyCheckAlgorithmintegrate withSingleTableDataCalculatorScalingDataConsistencyCheckAlgorithmdefault implScalingAPIImplSingleTableDataCalculator, source and target database type could be differentdataConsistencyCheckAlgorithmconfig inserver.yaml