Skip to content

Comments

Integrate templates to support rule composition#14643

Merged
terrymanu merged 1 commit intoapache:masterfrom
totalo:refactor-0108
Jan 10, 2022
Merged

Integrate templates to support rule composition#14643
terrymanu merged 1 commit intoapache:masterfrom
totalo:refactor-0108

Conversation

@totalo
Copy link
Member

@totalo totalo commented Jan 9, 2022

For #12366.

Changes proposed in this pull request:

  • integrate templates to support rule composition

@codecov-commenter
Copy link

Codecov Report

Merging #14643 (4a9061a) into master (ff8fa34) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #14643      +/-   ##
============================================
- Coverage     59.65%   59.54%   -0.12%     
- Complexity     1844     1846       +2     
============================================
  Files          3026     3029       +3     
  Lines         45052    45129      +77     
  Branches       7614     7628      +14     
============================================
- Hits          26876    26870       -6     
- Misses        16077    16163      +86     
+ Partials       2099     2096       -3     
Impacted Files Coverage Δ
...he/shardingsphere/mode/manager/ContextManager.java 62.11% <0.00%> (-20.27%) ⬇️
...d/OnRuleAlteredActionConfigurationYamlSwapper.java 81.39% <0.00%> (-18.61%) ⬇️
...andler/query/ShardingTableNodesQueryResultSet.java 71.15% <0.00%> (-9.70%) ⬇️
...base/metadata/dialect/SQL92DataSourceMetaData.java 90.90% <0.00%> (-9.10%) ⬇️
.../metadata/dialect/SQLServerDataSourceMetaData.java 90.90% <0.00%> (-9.10%) ⬇️
...ase/metadata/dialect/OracleDataSourceMetaData.java 95.00% <0.00%> (-5.00%) ⬇️
...atabase/metadata/dialect/H2DataSourceMetaData.java 67.56% <0.00%> (-1.88%) ⬇️
...re/infra/database/metadata/DataSourceMetaData.java 100.00% <0.00%> (ø)
...base/metadata/dialect/MySQLDataSourceMetaData.java 100.00% <0.00%> (ø)
...se/metadata/dialect/MariaDBDataSourceMetaData.java 100.00% <0.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8fa34...4a9061a. Read the comment docs.

@terrymanu terrymanu added this to the 5.1.1 milestone Jan 10, 2022
@terrymanu terrymanu merged commit cf472e4 into apache:master Jan 10, 2022
@totalo totalo deleted the refactor-0108 branch January 10, 2022 05:29
@menghaoranss menghaoranss modified the milestones: 5.1.1, 5.1.0 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants