Skip to content

Improve job progress swapper #20029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terrymanu merged 1 commit into from
Aug 9, 2022
Merged

Improve job progress swapper #20029

terrymanu merged 1 commit into from
Aug 9, 2022

Conversation

@sandynz
Copy link
Contributor

@sandynz sandynz commented Aug 9, 2022

Related to #19940.

Changes proposed in this pull request:

  • Improve job item tasks progress swapper, make it compatible with null value, avoid possible NPE in ShowScalingJobStatusQueryResultSet
  • Improve YamlJobProgressSwapperTest, 1) test swapToYaml and swapToObject, 2) test job-progress-failure.yaml secenario

@sandynz sandynz added this to the 5.1.3 milestone Aug 9, 2022
@terrymanu terrymanu merged commit 30bd2f7 into apache:master Aug 9, 2022
@sandynz sandynz deleted the scaling-2 branch August 10, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees

No one assigned

Labels

feature: pipeline type: enhancement type: refactor

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sandynz @terrymanu