Skip to content

Conversation

@zhaojinchao95
Copy link
Contributor

Fixes #19013

@zhaojinchao95 zhaojinchao95 marked this pull request as draft August 10, 2022 08:25
@zhaojinchao95 zhaojinchao95 marked this pull request as ready for review August 10, 2022 09:20
@menghaoranss
Copy link
Contributor

@ZjcNB please fix it

@zhaojinchao95 zhaojinchao95 marked this pull request as draft August 10, 2022 11:26
@zhaojinchao95
Copy link
Contributor Author

@ZjcNB please fix it

Ok, i will check

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #20053 (59925b4) into master (bebe441) will increase coverage by 0.02%.
The diff coverage is 63.15%.

@@             Coverage Diff              @@
##             master   #20053      +/-   ##
============================================
+ Coverage     60.62%   60.65%   +0.02%     
- Complexity     2414     2415       +1     
============================================
  Files          3850     3850              
  Lines         54704    54707       +3     
  Branches       7672     7673       +1     
============================================
+ Hits          33164    33182      +18     
+ Misses        18685    18667      -18     
- Partials       2855     2858       +3     
Impacted Files Coverage Δ
...sher/type/CreateTableStatementSchemaRefresher.java 11.76% <0.00%> (ø)
...ardingsphere/singletable/rule/SingleTableRule.java 60.63% <0.00%> (-0.66%) ⬇️
...he/shardingsphere/mode/manager/ContextManager.java 62.77% <28.57%> (-1.07%) ⬇️
...nfra/metadata/database/ShardingSphereDatabase.java 84.61% <100.00%> (+17.11%) ⬆️
...data/database/rule/ShardingSphereRuleMetaData.java 86.66% <0.00%> (-6.67%) ⬇️
...distsql/ral/queryable/ShowInstanceInfoHandler.java 87.50% <0.00%> (ø)
...handler/distsql/ral/hint/enums/HintSourceType.java 42.85% <0.00%> (+42.85%) ⬆️
...distsql/ral/queryable/ShowInstanceListHandler.java 76.92% <0.00%> (+76.92%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaojinchao95 zhaojinchao95 marked this pull request as ready for review August 11, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider provide a way to refresh only the SingleTableRule

4 participants