Add : add a new action only focus on checkstyle check #20269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaCN
reviewed
Aug 18, 2022
| uses: actions/cache@v2 | ||
| with: | ||
| path: ~/.m2/repository | ||
| key: shardingsphere-it-cache-${{ github.sha }} |
Contributor
Author
There was a problem hiding this comment.
I was thinking about how to caching the plugin related but not the rest dependencies.
this is a good refactor point.
TeslaCN
reviewed
Aug 18, 2022
| uses: actions/cache@v2 | ||
| with: | ||
| path: ~/.m2/repository | ||
| key: shardingsphere-checkstyle-check-cache-${{ github.sha }} |
Member
There was a problem hiding this comment.
The cache will always be absent if using github.sha here. It will always use the restore key.
Contributor
Author
There was a problem hiding this comment.
how about followings key. this key is better than the previous key+restore key combination.
key: ${{ runner.os }}-checkstyle-check-${{ hashFiles('.github/workflows/checkstyle-check.yml') }}
terrymanu
requested changes
Aug 18, 2022
Member
terrymanu
left a comment
terrymanu
left a comment
There was a problem hiding this comment.
checkstyle-and-apache-rat in it.yml has already existed
Contributor
Author
|
test on my own repository as followings :
|
terrymanu
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.