Skip to content

Conversation

@huangdx0726
Copy link
Contributor

Fixes #20379 .

Changes proposed in this pull request:

@codecov-commenter
Copy link

Codecov Report

Merging #20758 (cb5f0b0) into master (fabe8b8) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #20758   +/-   ##
=========================================
  Coverage     61.26%   61.26%           
- Complexity     2419     2420    +1     
=========================================
  Files          3980     3980           
  Lines         55225    55225           
  Branches       9373     9373           
=========================================
+ Hits          33831    33834    +3     
+ Misses        18512    18510    -2     
+ Partials       2882     2881    -1     
Impacted Files Coverage Δ
...ialect/handler/ddl/DropSchemaStatementHandler.java 100.00% <0.00%> (+40.00%) ⬆️
...nt/sqlserver/ddl/SQLServerDropSchemaStatement.java 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

}

@Test
public void assertIsContainsCascadeForSQLServer() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename assertIsContainsCascadeForXXX to assertContainsCascadeForXXX

@strongduanmu strongduanmu merged commit ce56fce into apache:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more unit test for DropSchemaStatementHandler

3 participants