Add optimized plan cache. #21149
Closed
Add optimized plan cache. #21149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyjoy1127
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21149 +/- ##
============================================
- Coverage 61.64% 61.62% -0.03%
Complexity 2487 2487
============================================
Files 4062 4063 +1
Lines 55891 55913 +22
Branches 9440 9442 +2
============================================
- Hits 34456 34455 -1
- Misses 18559 18582 +23
Partials 2876 2876
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TeslaCN
reviewed
Sep 24, 2022
| } | ||
|
|
||
| private Cache<String, SQLOptimizeContext> buildCache() { | ||
| return CacheBuilder.newBuilder() |
Member
There was a problem hiding this comment.
How about using Caffeine cache?
Contributor
Author
There was a problem hiding this comment.
Why use Caffine cache, does it have any benefits? @TeslaCN
Member
There was a problem hiding this comment.
- The performance of Caffeine is better than Guava in most scenario.
- And ShardingSphere is reducing usage of Guava.
The SQL parser cache has been migrated to Caffeine in #17712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #19937
Changes proposed in this pull request: