Skip to content

Conversation

@betterjava
Copy link
Member

Fixes #2126 .

Changes proposed in this pull request:
-add SQLLoggerTest to test SQLLogger

@coveralls
Copy link

coveralls commented Mar 30, 2019

Pull Request Test Coverage Report for Build 7421

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 116 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.1%) to 54.374%

Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/InsertSegment.java 1 0.0%
sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/core/merge/dql/DQLMergeEngine.java 1 88.37%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/column/ColumnSegment.java 4 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/extractor/impl/TableNameExtractor.java 6 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/extractor/impl/dml/InsertExtractor.java 6 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/parser/token/TableToken.java 7 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/encrypt/segment/impl/EncryptInsertFiller.java 7 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/table/TableSegment.java 8 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/segment/impl/dql/OrderItemBuilder.java 9 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/sharding/statement/impl/dml/InsertFiller.java 15 0.0%
Totals Coverage Status
Change from base Build 7399: 0.1%
Covered Lines: 8484
Relevant Lines: 15603

💛 - Coveralls

@betterjava
Copy link
Member Author

@terrymanu can you help me to review my pull ?

@terrymanu terrymanu added this to the 4.0.0.M2 milestone Apr 1, 2019
@terrymanu
Copy link
Member

The idea of mock test is good. Cloud you use checkstyle to check your code and fix waring of your code?

@terrymanu
Copy link
Member

@betterjava
Copy link
Member Author

OK,I have used checkstyle,but seems not work fo Test class.I will check.

@betterjava
Copy link
Member Author

I am sorry to set the wrong property for checkstyle. I have checked the code with the correct checkstyle config.

@terrymanu
Copy link
Member

That's prefect, I will merge them

@terrymanu terrymanu merged commit 9bb141e into apache:dev Apr 1, 2019
@terrymanu terrymanu modified the milestones: 4.0.0.M2, 4.0.0.M1 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants