Skip to content

Conversation

@strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Oct 10, 2022

Fixes #21417.

Changes proposed in this pull request:

  • optimize combine statement convert logic when statement contains order by and limit
  • optimize SQLFederationRowEnumerator logic for combine statement
  • add unit test and integration test

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have passed maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@tristaZero tristaZero merged commit 865fd40 into apache:master Oct 10, 2022
@strongduanmu strongduanmu deleted the dev branch October 10, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SELECT UNION ALL statement return wrong result when execute with ADVANCED SQL Federation

2 participants