Skip to content

Conversation

@azexcy
Copy link
Contributor

@azexcy azexcy commented Oct 12, 2022

the merge method may merge INSERT and DELETE operations, so calculatate count before merge

Changes proposed in this pull request:

  • Calculate processed records count before merged operation
  • Improve mysql client reconnect

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have passed maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@azexcy
Copy link
Contributor Author

azexcy commented Oct 12, 2022

the ci process result

dataSourceName: ds_0
incremental:
  delay:
    lastEventTimestamps: 1665537963000
    latestActiveTimeMillis: 1665537966842
  position: binlog.000001#182842306
inventory:
  finished:
  - ds_0.t_order_copy#0
processedRecordsCount: 3015
sourceDatabaseType: MySQL
status: EXECUTE_INCREMENTAL_TASK

now the processedRecordsCount is correct when increment task is runing.

@sandynz sandynz merged commit 3b72b03 into apache:master Oct 12, 2022
@azexcy azexcy deleted the dev branch October 12, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants