Skip to content

Conversation

@totalo
Copy link
Member

@totalo totalo commented Dec 29, 2022

For #12366.

Changes proposed in this pull request:

  • Update the module hierarchy for the parser example

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@totalo totalo added this to the 5.3.1 milestone Dec 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #23156 (ad06119) into master (bbae7b7) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #23156      +/-   ##
============================================
+ Coverage     49.87%   49.98%   +0.11%     
+ Complexity     2439     2437       -2     
============================================
  Files          4111     4114       +3     
  Lines         57587    57616      +29     
  Branches       9098     9099       +1     
============================================
+ Hits          28719    28797      +78     
+ Misses        26343    26287      -56     
- Partials       2525     2532       +7     
Impacted Files Coverage Δ
...handler/distsql/ral/hint/enums/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️
.../CreateReadwriteSplittingRuleStatementUpdater.java 68.75% <0.00%> (-1.25%) ⬇️
...ingsphere/agent/bootstrap/ShardingSphereAgent.java 0.00% <0.00%> (ø)
...encrypt/algorithm/encrypt/MD5EncryptAlgorithm.java 100.00% <0.00%> (ø)
...yaml/swapper/YamlMaskRuleConfigurationSwapper.java 95.65% <0.00%> (ø)
...trap/plugin/loader/AdvisorConfigurationLoader.java 0.00% <0.00%> (ø)
...trap/transformer/builder/advise/AdviceFactory.java 83.33% <0.00%> (ø)
...ore/ReadwriteSplittingDistSQLStatementVisitor.java 0.00% <0.00%> (ø)
...cket/command/query/MySQLColumnFieldDetailFlag.java
...lgorithm/cover/MaskBeforeSpecialCharAlgorithm.java
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@strongduanmu strongduanmu merged commit e65aa37 into apache:master Jan 1, 2023
@totalo totalo deleted the remove-module branch January 5, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants