Skip to content

Conversation

@Qianyi951015
Copy link
Contributor

For #23854.

Changes proposed in this pull request:

  • Replace ConvertYamlConfigurationHandler with ConvertYamlConfigurationExecutor

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@Qianyi951015 Qianyi951015 marked this pull request as draft February 1, 2023 07:46
@codecov-commenter
Copy link

Codecov Report

Merging #23896 (af0633d) into master (991e96a) will increase coverage by 0.01%.
The diff coverage is 67.85%.

❗ Current head af0633d differs from pull request most recent head b4ca270. Consider uploading reports for the commit b4ca270 to get more accurate results

@@             Coverage Diff              @@
##             master   #23896      +/-   ##
============================================
+ Coverage     50.17%   50.19%   +0.01%     
- Complexity     1570     1571       +1     
============================================
  Files          3247     3247              
  Lines         53455    53480      +25     
  Branches       9795     9799       +4     
============================================
+ Hits          26819    26842      +23     
+ Misses        24279    24278       -1     
- Partials       2357     2360       +3     
Impacted Files Coverage Δ
...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java 64.10% <0.00%> (ø)
...ReplicationDatabaseDiscoveryProviderAlgorithm.java 19.04% <0.00%> (-2.01%) ⬇️
...here/mask/algorithm/MaskAlgorithmPropsChecker.java 100.00% <ø> (ø)
...e/mode/metadata/storage/StorageNodeDataSource.java 0.00% <ø> (ø)
...tor/subscriber/ConfigurationChangedSubscriber.java 79.41% <0.00%> (ø)
.../handler/distsql/ral/RALBackendHandlerFactory.java 70.73% <ø> (-0.70%) ⬇️
.../ShowStatusFromReadwriteSplittingRulesHandler.java 0.00% <0.00%> (ø)
...iteSplittingStorageUnitStatusStatementHandler.java 0.00% <0.00%> (ø)
...dbdiscovery/algorithm/DatabaseDiscoveryEngine.java 35.00% <44.44%> (+2.50%) ⬆️
...pe/MGRMySQLDatabaseDiscoveryProviderAlgorithm.java 53.62% <50.00%> (-0.11%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Qianyi951015 Qianyi951015 marked this pull request as ready for review February 1, 2023 09:31
@RaigorJiang RaigorJiang added this to the 5.3.2 milestone Feb 1, 2023
@RaigorJiang RaigorJiang merged commit 1ad1f8c into apache:master Feb 1, 2023
@Qianyi951015 Qianyi951015 deleted the convert_yaml_config branch February 1, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants