Skip to content

Conversation

@surukonda
Copy link
Contributor

Fixes #23964.

Changes proposed in this pull request:

  • Enforcing Postgres standard_conforming_strings to "on" to handle issues associated to gorm while handling boolean values.

Before committing this PR, I'm sure that I have checked the following options:

  • [X ] My code follows the code of conduct of this project.
  • [ X] I have self-reviewed the commit code.
  • [ X] I have (or in comment I request) added corresponding labels for the pull request.
  • [X ] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • [ X] I have made corresponding changes to the documentation.
  • [ X] I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

Codecov Report

Merging #24038 (c5f8591) into master (946080b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #24038      +/-   ##
============================================
+ Coverage     50.07%   50.12%   +0.05%     
- Complexity     1562     1567       +5     
============================================
  Files          3238     3249      +11     
  Lines         53246    53321      +75     
  Branches       9798     9819      +21     
============================================
+ Hits          26662    26728      +66     
- Misses        24232    24239       +7     
- Partials       2352     2354       +2     
Impacted Files Coverage Δ
...authentication/PostgreSQLAuthenticationEngine.java 88.88% <100.00%> (+0.31%) ⬆️
...handler/distsql/ral/hint/enums/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️
...abase/resource/ShardingSphereResourceMetaData.java 65.62% <0.00%> (-1.05%) ⬇️
...e/proxy/backend/handler/cdc/CDCBackendHandler.java 10.00% <0.00%> (ø)
...single/metadata/SingleSchemaMetaDataDecorator.java 100.00% <0.00%> (ø)
...dingsphere/data/pipeline/cdc/client/CDCClient.java 0.00% <0.00%> (ø)
...ngsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java 0.00% <0.00%> (ø)
...data/pipeline/cdc/client/util/AnyValueConvert.java 0.00% <0.00%> (ø)
...eline/cdc/client/sqlbuilder/SQLBuilderFactory.java 0.00% <0.00%> (ø)
...ne/cdc/client/context/ClientConnectionContext.java 0.00% <0.00%> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaojinchao95
Copy link
Contributor

@TeslaCN Hi, can you review this pull request ?

@TeslaCN TeslaCN added this to the 5.3.2 milestone Feb 7, 2023
@TeslaCN TeslaCN merged commit bae5796 into apache:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean type giving error in ShardingSphere while insert

4 participants