Skip to content

Tracing: close the span when an exception is thrown #24142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RaigorJiang merged 2 commits into from
Feb 13, 2023
Merged

Tracing: close the span when an exception is thrown #24142

RaigorJiang merged 2 commits into from
Feb 13, 2023

Conversation

@jiangML
Copy link
Contributor

@jiangML jiangML commented Feb 13, 2023 •
edited
Loading

Fixes #24140.

Changes proposed in this pull request:

  • close the span when an exception is thrown

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@RaigorJiang RaigorJiang added this to the 5.3.2 milestone Feb 13, 2023
@RaigorJiang RaigorJiang merged commit b904bfd into apache:master Feb 13, 2023
@jiangML jiangML deleted the optimize-tracing branch February 16, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaigorJiang RaigorJiang RaigorJiang approved these changes

Assignees

No one assigned

Labels

feature: agent shardingsphere agent type: enhancement

Projects

None yet

Milestone

5.3.2

Development

Successfully merging this pull request may close these issues.

Tracing: close the span when an exception is thrown

2 participants

@jiangML @RaigorJiang