Skip to content

Conversation

@gxxiong
Copy link
Member

@gxxiong gxxiong commented Mar 8, 2023

Fixes #24337 .

Changes proposed in this pull request:
-Encrypt like supports concat function

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #24502 (f5b2a4e) into master (ea06d6a) will decrease coverage by 0.01%.
The diff coverage is 36.84%.

❗ Current head f5b2a4e differs from pull request most recent head a51f7f4. Consider uploading reports for the commit a51f7f4 to get more accurate results

@@             Coverage Diff              @@
##             master   #24502      +/-   ##
============================================
- Coverage     50.20%   50.19%   -0.01%     
- Complexity     1599     1600       +1     
============================================
  Files          3299     3300       +1     
  Lines         53981    54019      +38     
  Branches       9927     9938      +11     
============================================
+ Hits          27100    27114      +14     
- Misses        24461    24482      +21     
- Partials       2420     2423       +3     
Impacted Files Coverage Δ
...ator/EncryptPredicateRightValueTokenGenerator.java 44.89% <0.00%> (-6.27%) ⬇️
...rewrite/condition/impl/EncryptBinaryCondition.java 44.11% <9.09%> (-16.76%) ⬇️
.../pojo/EncryptPredicateFunctionRightValueToken.java 61.90% <61.90%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gxxiong gxxiong requested a review from strongduanmu March 10, 2023 01:27
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

@strongduanmu strongduanmu merged commit cb140a2 into apache:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using the 'like' operator to perform a fuzzy search on an encrypted column in version 5.3.0.

3 participants