Skip to content

Conversation

@RaigorJiang
Copy link
Contributor

Fixes #24557.

Cause Analysis:

When the time zone is New Zealand, assertWriteWithTwelveBytes will fail, because the time zone of New Zealand is GMT+12, and the hourOfDay corresponding to GMT 0 o'clock is 12, which will cause writeInt1(12) to be called twice.


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@RaigorJiang RaigorJiang added this to the 5.3.2 milestone Mar 13, 2023
@zhaojinchao95 zhaojinchao95 merged commit 7ec421b into apache:master Mar 13, 2023
@RaigorJiang RaigorJiang deleted the dev-24557 branch March 13, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time zone changes lead to test failure

2 participants