Skip to content

fix ReadwriteRule checkReadeDataSource and test #24669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhaojinchao95 merged 1 commit into from
Mar 22, 2023
Merged

fix ReadwriteRule checkReadeDataSource and test #24669

zhaojinchao95 merged 1 commit into from
Mar 22, 2023

Conversation

@hua74ni
Copy link
Contributor

@hua74ni hua74ni commented Mar 17, 2023 •
edited
Loading

Changes proposed in this pull request:

  • fix ReadwriteRule checkReadeDataSource and test(The problem is that the readwrite splitting rule the slave dataSource are not verified as expected)

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@hua74ni
Copy link
Contributor Author

hua74ni commented Mar 21, 2023

What else I need to do for this PR @gxxiong

@zhaojinchao95 zhaojinchao95 added this to the 5.3.3 milestone Mar 22, 2023
@zhaojinchao95 zhaojinchao95 merged commit 034b724 into apache:master Mar 22, 2023
@zhaojinchao95
Copy link
Contributor

zhaojinchao95 commented Mar 22, 2023

What else I need to do for this PR @gxxiong

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

Assignees

No one assigned

Labels

feature: readwrite-splitting type: fixed

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hua74ni @zhaojinchao95 @gxxiong