Refactor LoadBalanceAlgorithm

features/readwrite-splitting/api/src/main/java/org/apache/shardingsphere/readwritesplitting/api/transaction/TransactionReadQueryStrategy.java

@@ -21,5 +21,6 @@
  * Transaction read query strategy.
  */
 public enum TransactionReadQueryStrategy {
+
     FIXED_PRIMARY, FIXED_REPLICA, DYNAMIC_REPLICA
 }

features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/algorithm/loadbalance/RandomReadQueryLoadBalanceAlgorithm.java

@@ -36,9 +36,7 @@ public final class RandomReadQueryLoadBalanceAlgorithm implements ReadQueryLoadB
 
     @Override
     public void init(final Properties props) {
-        transactionReadQueryStrategy = props.containsKey(TRANSACTION_READ_QUERY_STRATEGY)
-                ? TransactionReadQueryStrategy.valueOf(props.getProperty(TRANSACTION_READ_QUERY_STRATEGY))
-                : TransactionReadQueryStrategy.FIXED_PRIMARY;
+        transactionReadQueryStrategy = TransactionReadQueryStrategy.valueOf(props.getProperty(TRANSACTION_READ_QUERY_STRATEGY, TransactionReadQueryStrategy.FIXED_PRIMARY.name()));
     }
 
     @Override
@@ -50,12 +48,12 @@ public String getDataSource(final String name, final String writeDataSourceName,
     }
 
     @Override
-    public String getType() {
-        return "RANDOM";
+    public String getDataSourceName(final String name, final List<String> readDataSourceNames) {
+        return readDataSourceNames.get(ThreadLocalRandom.current().nextInt(readDataSourceNames.size()));
     }
 
     @Override
-    public String getDataSourceName(final String name, final List<String> readDataSourceNames) {
-        return readDataSourceNames.get(ThreadLocalRandom.current().nextInt(readDataSourceNames.size()));
+    public String getType() {
+        return "RANDOM";
     }
 }

features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/algorithm/loadbalance/RoundRobinReadQueryLoadBalanceAlgorithm.java

@@ -38,9 +38,7 @@ public final class RoundRobinReadQueryLoadBalanceAlgorithm implements ReadQueryL
 
     @Override
     public void init(final Properties props) {
-        transactionReadQueryStrategy = props.containsKey(TRANSACTION_READ_QUERY_STRATEGY)
-                ? TransactionReadQueryStrategy.valueOf(props.getProperty(TRANSACTION_READ_QUERY_STRATEGY))
-                : TransactionReadQueryStrategy.FIXED_PRIMARY;
+        transactionReadQueryStrategy = TransactionReadQueryStrategy.valueOf(props.getProperty(TRANSACTION_READ_QUERY_STRATEGY, TransactionReadQueryStrategy.FIXED_PRIMARY.name()));
     }
 
     @Override
@@ -51,6 +49,11 @@ public String getDataSource(final String name, final String writeDataSourceName,
         return getDataSourceName(name, readDataSourceNames);
     }
 
+    @Override
+    public String getDataSourceName(final String name, final List<String> readDataSourceNames) {
+        return readDataSourceNames.get(Math.abs(count.getAndIncrement()) % readDataSourceNames.size());
+    }
+
     @Override
     public String getType() {
         return "ROUND_ROBIN";
@@ -60,9 +63,4 @@ public String getType() {
     public boolean isDefault() {
         return true;
     }
-
-    @Override
-    public String getDataSourceName(final String name, final List<String> readDataSourceNames) {
-        return readDataSourceNames.get(Math.abs(count.getAndIncrement()) % readDataSourceNames.size());
-    }
 }

features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/algorithm/loadbalance/WeightReadQueryLoadBalanceAlgorithm.java

@@ -56,13 +56,10 @@ public final class WeightReadQueryLoadBalanceAlgorithm implements ReadQueryLoadB
     @Override
     public void init(final Properties props) {
         this.props = props;
-        if (props.containsKey(TRANSACTION_READ_QUERY_STRATEGY)) {
-            transactionReadQueryStrategy = TransactionReadQueryStrategy.valueOf(props.getProperty(TRANSACTION_READ_QUERY_STRATEGY));
-            dataSourceNames = props.stringPropertyNames().stream().filter(each -> !each.equals(TRANSACTION_READ_QUERY_STRATEGY)).collect(Collectors.toList());
-        } else {
-            transactionReadQueryStrategy = TransactionReadQueryStrategy.FIXED_PRIMARY;
-            dataSourceNames = props.stringPropertyNames();
-        }
+        transactionReadQueryStrategy = TransactionReadQueryStrategy.valueOf(props.getProperty(TRANSACTION_READ_QUERY_STRATEGY, TransactionReadQueryStrategy.FIXED_PRIMARY.name()));
+        dataSourceNames = props.containsKey(TRANSACTION_READ_QUERY_STRATEGY)
+                ? props.stringPropertyNames().stream().filter(each -> !each.equals(TRANSACTION_READ_QUERY_STRATEGY)).collect(Collectors.toList())
+                : props.stringPropertyNames();
     }
 
     @Override

features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/transaction/TransactionReadQueryStrategyUtil.java

@@ -17,6 +17,8 @@
 
 package org.apache.shardingsphere.readwritesplitting.transaction;
 
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
 import org.apache.shardingsphere.infra.context.transaction.TransactionConnectionContext;
 import org.apache.shardingsphere.readwritesplitting.api.transaction.TransactionReadQueryStrategy;
 import org.apache.shardingsphere.readwritesplitting.api.transaction.TransactionReadQueryStrategyAware;
@@ -26,7 +28,8 @@
 /**
  * Transaction read query strategy util.
  */
-public class TransactionReadQueryStrategyUtil {
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class TransactionReadQueryStrategyUtil {
 
     /**
      * Get data source name in transaction.