Skip to content

Conversation

@zihaoAK47
Copy link
Member

Refer #25535.

Changes proposed in this pull request:

  • Add mysql select InExpression parse
  • Add test

Before committing this PR, I'm sure that I have checked the following options:

  • [ ✓] My code follows the code of conduct of this project.
  • [ ✓] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • [ ✓] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • [ ✓] I have added corresponding unit tests for my changes.

@zihaoAK47
Copy link
Member Author

@strongduanmu Please view.

@strongduanmu
Copy link
Member

@strongduanmu Please view.

Hi @zihaoAK47, can you take a look for ci error?

@zihaoAK47
Copy link
Member Author

@strongduanmu Please view.

Hi @zihaoAK47, can you take a look for ci error?

Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error: Process completed with exit code 1.

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

@strongduanmu strongduanmu merged commit 71c24ee into apache:master Jul 4, 2023
@zihaoAK47 zihaoAK47 deleted the dev_select branch July 5, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants