Skip to content

Conversation

@zihaoAK47
Copy link
Member

Refer #25535.

Changes proposed in this pull request:

  • EXECUTE ps1 USING @expected, @db, @table
  • Add table rule in identifierKeywordsUnambiguous

Before committing this PR, I'm sure that I have checked the following options:

  • [ ✓] My code follows the code of conduct of this project.
  • [ ✓] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • [ ✓] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • [ ✓] I have added corresponding unit tests for my changes.

@zihaoAK47
Copy link
Member Author

@strongduanmu Please review thank 😏

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zihaoAK47 Can you test sql parser test case for this change?

@strongduanmu strongduanmu modified the milestones: 5.5.0, 5.4.0 Jun 26, 2023
@zihaoAK47
Copy link
Member Author

@strongduanmu
Hi mentor, I have added the test but this error occurred in CI
Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
The above error seems to be that the corresponding jar package was not found in the repository.
This error often appears in my submitted PR. Can you tell me how to solve it? Thank you.

@strongduanmu
Copy link
Member

@strongduanmu Hi mentor, I have added the test but this error occurred in CI Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1] The above error seems to be that the corresponding jar package was not found in the repository. This error often appears in my submitted PR. Can you tell me how to solve it? Thank you.

I have triggered the ci, let's see the new result.

@zihaoAK47
Copy link
Member Author

@strongduanmu Hi mentor, I have added the test but this error occurred in CI Error: Failed to execute goal on project shardingsphere-test-e2e-sql: Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-test-e2e-sql:jar:5.3.3-SNAPSHOT: Could not find artifact org.apache.shardingsphere:shardingsphere-test-e2e-env:jar:tests:5.3.3-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1] The above error seems to be that the corresponding jar package was not found in the repository. This error often appears in my submitted PR. Can you tell me how to solve it? Thank you.

I have triggered the ci, let's see the new result.

Aha, everything has passed the inspection 😊

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zihaoAK47 Good job, merged.

@strongduanmu strongduanmu merged commit 31b763a into apache:master Jun 28, 2023
@zihaoAK47 zihaoAK47 deleted the dev_execute branch June 28, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants