Decouple ParameterBuilder and route#3214
Merged
terrymanu merged 8 commits intoapache:devfrom Oct 10, 2019
terrymanu:issue3139
Merged
Decouple ParameterBuilder and route#3214terrymanu merged 8 commits intoapache:devfrom terrymanu:issue3139
terrymanu merged 8 commits intoapache:devfrom
terrymanu:issue3139
Conversation
tristaZero
approved these changes
Oct 10, 2019
Pull Request Test Coverage Report for Build 566
💛 - Coveralls |
Pramy
pushed a commit
to Pramy/sharding-sphere
that referenced
this pull request
Oct 10, 2019
* remove getter of GroupedParameterBuilder.parameterGroups * rename GroupedParameterBuilder.parameterGroups to groupedParameters * add GroupedParameterBuilder.getParameters(count) * move sharding logic from GroupedParameterBuilder to ShardingSQLRewriteEngine * remove GroupedParameterBuilder.shardingConditions * refactor ShardingSQLRewriteEngine * reuse StandardParameterBuilder on GroupedParameterBuilder * refactor ParameterRewriterBuilder.getParameterRewriters()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3139.