Skip to content

Firebird BLOB handling #37909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terrymanu merged 10 commits into from
Jan 30, 2026
Merged

Firebird BLOB handling #37909

terrymanu merged 10 commits into from
Jan 30, 2026
+1,691 −198

Conversation

@makssent
Copy link
Contributor

@makssent makssent commented Jan 30, 2026

Changes proposed in this pull request:

  • Fixed SELECT and UPDATE with BLOBs (Firebird).
  • Separated BLOB metadata resolution from max_size handling for non-BLOB columns.
  • Other minor, targeted fixes in Firebird BLOB handling.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@makssent makssent changed the title finalize Firebird BLOB handling Firebird BLOB handling Jan 30, 2026
@makssent makssent marked this pull request as ready for review January 30, 2026 12:18
@terrymanu terrymanu added this to the 5.5.3 milestone Jan 30, 2026
@terrymanu terrymanu merged commit cdfceec into apache:master Jan 30, 2026
147 checks passed
jiangML pushed a commit to jiangML/shardingsphere that referenced this pull request Jan 30, 2026
@makssent @jiangML
Firebird BLOB handling (apache#37909)
04145dd 
* revert binaryColumnType data type sizes

* add info_blob implementation

* Add BlobBinary protocol value for Firebird BLOB

* separate max_size retrieval from BLOB metadata

* Blob impl

* update blob tests

* checkstyle and spotless fix

* correct tests

* correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrymanu terrymanu terrymanu approved these changes

Assignees

No one assigned

Labels

db: Firebird in: proxy type: enhancement

Projects

None yet

Milestone

5.5.3

Development

Successfully merging this pull request may close these issues.

2 participants

@makssent @terrymanu