Skip to content

Unify AST rule name#4331

Merged
tristaZero merged 5 commits intoapache:masterfrom
terrymanu:parser
Feb 16, 2020
Merged

Unify AST rule name#4331
tristaZero merged 5 commits intoapache:masterfrom
terrymanu:parser

Conversation

@terrymanu
Copy link
Member

For #4277.

@codecov-io
Copy link

Codecov Report

Merging #4331 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4331   +/-   ##
=========================================
  Coverage     54.22%   54.22%           
  Complexity      352      352           
=========================================
  Files          1045     1045           
  Lines         19216    19216           
  Branches       3531     3531           
=========================================
  Hits          10419    10419           
  Misses         8142     8142           
  Partials        655      655
Impacted Files Coverage Δ Complexity Δ
...e/sql/parser/visitor/impl/SQLServerDDLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...phere/sql/parser/visitor/impl/SQL92DDLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ngsphere/sql/parser/visitor/PostgreSQLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/sql/parser/visitor/impl/SQLServerDCLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...phere/sql/parser/visitor/impl/MySQLDALVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...phere/sql/parser/visitor/impl/SQL92DCLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...hardingsphere/sql/parser/visitor/MySQLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...here/sql/parser/visitor/impl/OracleDDLVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c648d82...e8bdaa9. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 16, 2020

Pull Request Test Coverage Report for Build 1759

  • 0 of 38 (0.0%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 57.686%

Changes Missing Coverage Covered Lines Changed/Added Lines %
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDALVisitor.java 0 1 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DCLVisitor.java 0 1 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDDLVisitor.java 0 1 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java 0 2 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDDLVisitor.java 0 2 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java 0 2 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQLServerDCLVisitor.java 0 14 0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DDLVisitor.java 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/SQL92DDLVisitor.java 1 0%
Totals Coverage Status
Change from base Build 866: 0.0%
Covered Lines: 11085
Relevant Lines: 19216

💛 - Coveralls

@tristaZero tristaZero merged commit 5958f19 into apache:master Feb 16, 2020
@terrymanu terrymanu deleted the parser branch February 16, 2020 13:16
@terrymanu terrymanu modified the milestones: 5.0.0, 4.1.0 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants