Skip to content

Opt curator-client in unit test #4894

Merged
terrymanu merged 4 commits intoapache:masterfrom
kimmking:optZKUT
Mar 23, 2020
Merged

Opt curator-client in unit test #4894
terrymanu merged 4 commits intoapache:masterfrom
kimmking:optZKUT

Conversation

@kimmking
Copy link
Member

Fixes #4773 .

Changes proposed in this pull request:

  • 1、Remove testserver renewing and keep only one server during this test class running
  • 2、Use final CenterRepository "client" instead of clientA, keep only one client

@kimmking kimmking changed the title Opt curator- Opt curator-client in unit test Mar 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #4894 into master will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4894      +/-   ##
============================================
- Coverage     54.67%   54.65%   -0.03%     
+ Complexity      436      434       -2     
============================================
  Files          1138     1138              
  Lines         20412    20397      -15     
  Branches       3752     3749       -3     
============================================
- Hits          11161    11148      -13     
+ Misses         8547     8545       -2     
  Partials        704      704              
Impacted Files Coverage Δ Complexity Δ
...ter/instance/CuratorZookeeperCenterRepository.java 65.76% <50.00%> (-0.05%) 24.00 <1.00> (-2.00)
...rdingjdbc/jdbc/core/statement/ShadowStatement.java 62.50% <0.00%> (-1.14%) 0.00% <0.00%> (ø%)
...c/jdbc/core/statement/ShadowPreparedStatement.java 40.36% <0.00%> (-1.08%) 0.00% <0.00%> (ø%)
...dingjdbc/jdbc/core/statement/EncryptStatement.java 58.22% <0.00%> (-1.04%) 0.00% <0.00%> (ø%)
.../jdbc/core/statement/EncryptPreparedStatement.java 79.61% <0.00%> (-0.39%) 0.00% <0.00%> (ø%)
...org/apache/shardingsphere/core/rule/TableRule.java 85.26% <0.00%> (-0.16%) 1.00% <0.00%> (ø%)
.../shardingsphere/core/shard/BaseShardingEngine.java 86.95% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../core/metadata/ShardingTableMetaDataDecorator.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...r/binder/metadata/column/ColumnMetaDataLoader.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...dingsphere/underlying/rewrite/SQLRewriteEntry.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6885ec6...f058c0e. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 23, 2020

Pull Request Test Coverage Report for Build 10484

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 58.165%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java 3 76.0%
Totals Coverage Status
Change from base Build 1143: -0.007%
Covered Lines: 11864
Relevant Lines: 20397

💛 - Coveralls

@terrymanu terrymanu added this to the 4.1.0 milestone Mar 23, 2020
@terrymanu terrymanu merged commit 4a6aa0e into apache:master Mar 23, 2020
@kimmking kimmking deleted the optZKUT branch April 8, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CuratorZookeeperClient change-event bug in Unit Test

4 participants