ORDER BY merge result NPE#7878
Closed
waylink wants to merge 1 commit into
Closed
Conversation
Closed
Contributor
|
Thanks for your issue and the first PR @waylink ! Welcome your joining. I guess the author @terrymanu of the relevant programming can help review this one. Let us leave him some time. :) |
terrymanu
requested changes
Oct 22, 2020
Member
terrymanu
left a comment
terrymanu
left a comment
There was a problem hiding this comment.
It perhaps not the root cause.
Merge for order by should only process with sharding table only, if we pass all tables (allSchemaMetaData) can not help the root cause of NPE thrown.
It is better to investigate why sharding table got NPE first.
waylink
changed the title
Member
|
I test it works well. |
Member
|
I think we should close this pr. |
Member
|
Closed because changes are invalid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7877
Fixes #7877.
Changes proposed in this pull request: