Skip to content

refactor CuratorZookeeperRepository#7892

Merged
menghaoranss merged 1 commit into
apache:masterfrom
jacksparrow414:issue#7883
Oct 23, 2020
Merged

refactor CuratorZookeeperRepository#7892
menghaoranss merged 1 commit into
apache:masterfrom
jacksparrow414:issue#7883

Conversation

@jacksparrow414
Copy link
Copy Markdown
Contributor

Fixes #7883 .

Changes proposed in this pull request:

  • Replace com.google.common.base.Charsets with java.nio.charset.StandardCharsets in CuratorZookeeperRepository.java

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #7892 into master will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7892      +/-   ##
============================================
+ Coverage     74.69%   74.76%   +0.06%     
- Complexity      537      552      +15     
============================================
  Files          1449     1503      +54     
  Lines         22739    26269    +3530     
  Branches       4063     4884     +821     
============================================
+ Hits          16986    19639    +2653     
- Misses         4658     5305     +647     
- Partials       1095     1325     +230     
Impacted Files Coverage Δ Complexity Δ
...pository/zookeeper/CuratorZookeeperRepository.java 73.72% <66.66%> (ø) 26.00 <1.00> (ø)
...here/sql/parser/engine/ast/ASTSQLParserEngine.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ne/statement/standard/StandardSQLParserEngine.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...itor/statement/impl/OracleStatementSQLVisitor.java 73.93% <0.00%> (ø) 1.00% <0.00%> (?%)
...sql/visitor/format/impl/MySQLFormatSQLVisitor.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...tatement/impl/SQLServerDALStatementSQLVisitor.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../visitor/format/impl/MySQLDALFormatSQLVisitor.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...r/statement/impl/OracleDMLStatementSQLVisitor.java 85.29% <0.00%> (ø) 0.00% <0.00%> (?%)
...sql/visitor/PostgreSQLSQLVisitorFacadeFactory.java 66.66% <0.00%> (ø) 1.00% <0.00%> (?%)
...or/statement/impl/SQL92TCLStatementSQLVisitor.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83eb27f...9108a8b. Read the comment docs.

@menghaoranss menghaoranss merged commit c343c62 into apache:master Oct 23, 2020
@jacksparrow414 jacksparrow414 deleted the issue#7883 branch October 23, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace com.google.common.base.Charsets with java.nio.charset.StandardCharsets in CuratorZookeeperRepository.java

3 participants