AlibabaDubboServiceBeanListener

[wzhangNJ]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

hi，
shgenyu: 2.5.0
dubbo：2.6.2
issue：
Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
serviceBean.size() = 0

public void onApplicationEvent(@NonNull final ContextRefreshedEvent contextRefreshedEvent) {
        if (!registered.compareAndSet(false, true)) {
            return;
        }
        // Fix bug(https://github.com/apache/shenyu/issues/415), upload dubbo metadata on ContextRefreshedEvent
        Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
        for (Map.Entry<String, ServiceBean> entry : serviceBean.entrySet()) {
            handler(entry.getValue());
        }
        serviceBean.values()
                .stream()
                .findFirst()
                .ifPresent(bean -> publisher.publishEvent(buildURIRegisterDTO(bean)));
    }

Expected Behavior

Feign used，ContextRefreshedEvent is created multiple times.

 if (!registered.compareAndSet(false, true)) {
            return;
        }

First Feign ApplicationContext be triggered, registered is true.
in the future , otherv ApplicationContext may not be triggered.

public void onApplicationEvent(@NonNull final ContextRefreshedEvent contextRefreshedEvent) {
        // Fix bug(https://github.com/apache/shenyu/issues/415), upload dubbo metadata on ContextRefreshedEvent
        Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
        for (Map.Entry<String, ServiceBean> entry : serviceBean.entrySet()) {
            handler(entry.getValue());
        }
        serviceBean.values()
                .stream()
                .findFirst()
                .ifPresent(bean -> publisher.publishEvent(buildURIRegisterDTO(bean)));
    }

Steps To Reproduce

No response

Environment

ShenYu version(s):2.6.0

Debug logs

No response

Anything else?

No response

[KevinClair]

Maybe you can create a new listener?

[wzhangNJ]

Maybe you can create a new listener?
Because SpringCloudFeign create a new sub listener.

[wzhangNJ]

alibba dubbo

public void onApplicationEvent(@NonNull final ContextRefreshedEvent contextRefreshedEvent) {
        if (!registered.compareAndSet(false, true)) {
            return;
        }
        // Fix bug(https://github.com/apache/shenyu/issues/415), upload dubbo metadata on ContextRefreshedEvent
        Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
        for (Map.Entry<String, ServiceBean> entry : serviceBean.entrySet()) {
            handler(entry.getValue());
        }
        serviceBean.values()
                .stream()
                .findFirst()
                .ifPresent(bean -> publisher.publishEvent(buildURIRegisterDTO(bean)));
    }

apache dubbo

public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
        // Fix bug(https://github.com/apache/shenyu/issues/415), upload dubbo metadata on ContextRefreshedEvent
        Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
        if (serviceBean.isEmpty()) {
            return;
        }
        if (!registered.compareAndSet(false, true)) {
            return;
        }
        for (Map.Entry<String, ServiceBean> entry : serviceBean.entrySet()) {
            handler(entry.getValue());
        }
        serviceBean.values().stream().findFirst().ifPresent(bean -> {
            publisher.publishEvent(buildURIRegisterDTO(bean));
        });
    }

[KevinClair]

sorry,i don't understand you.

[wzhangNJ]

shenyu的dubbo插件alibaba和apache 两个版本，
AlibabaDubboServiceBeanListener的onApplicationEvent方法
因为onApplicationEvent的这段代码导致了Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);可能加载不进来

public void onApplicationEvent(@NonNull final ContextRefreshedEvent contextRefreshedEvent) {
// 如果第一次没有加载成功以后就不会加载了
        if (!registered.compareAndSet(false, true)) {
            return;
        }
        // Fix bug(https://github.com/apache/shenyu/issues/415), upload dubbo metadata on ContextRefreshedEvent
        Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
        for (Map.Entry<String, ServiceBean> entry : serviceBean.entrySet()) {
            handler(entry.getValue());
        }
        serviceBean.values()
                .stream()
                .findFirst()
                .ifPresent(bean -> publisher.publishEvent(buildURIRegisterDTO(bean)));
    }

我查看了shenyu的alibaba和apache两个版本的区别，发现apache的代码逻辑判断更严谨些

shenyu apache dubbo

public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
        // Fix bug(https://github.com/apache/shenyu/issues/415), upload dubbo metadata on ContextRefreshedEvent
        Map<String, ServiceBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceBean.class);
        if (serviceBean.isEmpty()) {
            return;
        }
        if (!registered.compareAndSet(false, true)) {
            return;
        }
        for (Map.Entry<String, ServiceBean> entry : serviceBean.entrySet()) {
            handler(entry.getValue());
        }
        serviceBean.values().stream().findFirst().ifPresent(bean -> {
            publisher.publishEvent(buildURIRegisterDTO(bean));
        });
    }

[KevinClair]

I understand you, can you fix it?

[loongs-zhang]

@wzhangNJ could you please fix it ?

[wzhangNJ]

@KevinClair can fix it