Skip to content

Conversation

@JooKS-me
Copy link
Member

@JooKS-me JooKS-me commented Jan 6, 2022

Fix #2719 .

@JooKS-me JooKS-me changed the title [type: refactor] Docker image support arm architecture [ISSUE #2719] Docker image support arm architecture Jan 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #2722 (747a717) into master (b75e222) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 747a717 differs from pull request most recent head f268524. Consider uploading reports for the commit f268524 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2722      +/-   ##
============================================
- Coverage     60.34%   60.31%   -0.03%     
+ Complexity     4399     4390       -9     
============================================
  Files           680      680              
  Lines         19468    19472       +4     
  Branches       1725     1727       +2     
============================================
- Hits          11748    11745       -3     
- Misses         6732     6740       +8     
+ Partials        988      987       -1     
Impacted Files Coverage Δ
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 54.25% <0.00%> (-9.58%) ⬇️
...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java 63.63% <0.00%> (-9.10%) ⬇️
...ache/shenyu/admin/utils/PluginHandleH2Trigger.java 63.63% <0.00%> (-9.10%) ⬇️
...enyu/admin/controller/DashboardUserController.java 93.10% <0.00%> (-6.90%) ⬇️
...u/admin/service/impl/DashboardUserServiceImpl.java 82.47% <0.00%> (-1.74%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 81.18% <0.00%> (+7.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75e222...f268524. Read the comment docs.

@yu199195 yu199195 merged commit 6ca0074 into apache:master Jan 7, 2022
@donlinglok1
Copy link

donlinglok1 commented Aug 1, 2022

Hi, @JooKS-me @yu199195

I am trying to pull the image from the official docker hub.
But seems both latest and 2.4.3 image of the admin and bootstrap container are marked as 'linux/arm64' only.
And it runs fail on windows and ubuntu with 'linux/amd64'.

I find this project has a GitHub Action to publish images to the docker hub, so I forked the master branch and test the action, below is the image I build, and run success on windows and ubuntu:
image

In conclusion, the official docker hub image may need to publish again.
Attached is the Github Action command log for your reference:

/usr/bin/docker buildx build --build-arg APP_NAME=apache-shenyu-*-admin-bin --iidfile /tmp/docker-build-push-Tdk9x6/iidfile --platform linux/amd64,linux/arm64 --tag ***/shenyuadmin:latest1 --tag ***/shenyuadmin:master --metadata-file /tmp/docker-build-push-Tdk9x6/metadata-file --push ./shenyu-dist/shenyu-admin-dist
/usr/bin/docker buildx build --build-arg APP_NAME=apache-shenyu-*-bootstrap-bin --iidfile /tmp/docker-build-push-XBGOK5/iidfile --platform linux/amd64,linux/arm64 --tag ***/shenyubootstrap:latest1 --tag ***/shenyubootstrap:master --metadata-file /tmp/docker-build-push-XBGOK5/metadata-file --push ./shenyu-dist/shenyu-bootstrap-dist

@yu199195
Copy link
Member

yu199195 commented Aug 1, 2022

@donlinglok thanks for you suggestion. In the next version will solve this problem, the previous version of the problem, perhaps we also need to update.

@JooKS-me
Copy link
Member Author

JooKS-me commented Aug 1, 2022

@donlinglok Thanks, I have updated the image, you can try it again.

@donlinglok1
Copy link

@donlinglok Thanks, I have updated the image, you can try it again.

Sorry, just find the exposed port is wrong on the bootstrap. Should be 9195?
image

@JooKS-me
Copy link
Member Author

JooKS-me commented Aug 1, 2022

Sorry, just find the exposed port is wrong on the bootstrap. Should be 9195?

The gateway should be 9195. If there are any questions, you can open an issue to describe your steps and configuration so that we can reproduce it.

@JooKS-me JooKS-me deleted the docker-arm branch August 1, 2022 12:58
@donlinglok1
Copy link

Sorry, just find the exposed port is wrong on the bootstrap. Should be 9195?

The gateway should be 9195. If there are any questions, you can open an issue to describe your steps and configuration so that we can reproduce it.

Sorry for my mistake, all image problem is solved after the fix! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Docker images run failed in arm architecture

4 participants