-
Notifications
You must be signed in to change notification settings - Fork 3k
[ISSUE #3794] websocket datasync can chose allow origin to avoid CSRF #3795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3794] websocket datasync can chose allow origin to avoid CSRF #3795
Conversation
|
hi,pls check ci |
Codecov Report
@@ Coverage Diff @@
## master #3795 +/- ##
============================================
- Coverage 64.20% 64.12% -0.09%
- Complexity 6033 6037 +4
============================================
Files 898 898
Lines 24649 24679 +30
Branches 2232 2238 +6
============================================
- Hits 15827 15826 -1
- Misses 7428 7457 +29
- Partials 1394 1396 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@847850277 hi, Can you tell us exactly what allow origin does? |
|
@yu199195 to avoid CSRF, In the case of Internet environment if someone knows admin websocket url,he can connect to ShenYu admin.Then forge the attack. |
|
Thanks, it merged~ |
Dear Community:
I have finished #3794
please review code.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.